Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numbering in Get Started #33736

Closed
wants to merge 1 commit into from
Closed

Fix numbering in Get Started #33736

wants to merge 1 commit into from

Conversation

jbogarthyde
Copy link
Contributor

@jbogarthyde jbogarthyde commented Nov 11, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Numbering of template steps reverts to 1 on step 4
Also, the previous PR landed only in Next.

Issue Number: #33213

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@jbogarthyde jbogarthyde requested a review from a team as a code owner November 11, 2019 16:43
@jbogarthyde jbogarthyde self-assigned this Nov 11, 2019
@ngbot ngbot bot modified the milestone: Backlog Nov 11, 2019
@mary-poppins
Copy link

You can preview ef074c6 at https://pr33736-ef074c6.ngbuilds.io/.

StephenFluin
StephenFluin suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want this. Markdown should automatically be interpreting the numbers into a sequence.

Aka in markdown if you have 1. 1. 1. 1. 1., it ends up being rendered as 1. 2. 3. 4. 5. Keeps code cleaner to use 1. 1. 1. 1. then.

Example (this is markdown with 1. 1. 1.)

  1. One
  2. Two
  3. Three

@jbogarthyde
Copy link
Contributor Author

@StephenFluin
It should be doing that, but it isn't.
See https://next.angular.io/start#template-syntax - Step 3 is followed by Step 1. This is a workaround.
(This is also a way to get the changes into the current doc, since it only landed in Next)

StephenFluin
StephenFluin approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@StephenFluin StephenFluin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works temporarily, but we should figure out what's wrong with our MD renderer. I tested it in another one and everything worked fine.

@jbogarthyde jbogarthyde added the action: merge The PR is ready for merge by the caretaker label Nov 11, 2019
kara pushed a commit that referenced this pull request Nov 11, 2019
@jbogarthyde @kara
docs: fix numbering (#33736)
ffb010d 
PR Close #33736
@kara kara closed this in c6ebcd1 Nov 11, 2019
@jbogarthyde jbogarthyde deleted the jb-start-intro branch November 11, 2019 21:25
@jbogarthyde jbogarthyde mentioned this pull request Nov 11, 2019
Closed
14 tasks
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenFluin StephenFluin StephenFluin approved these changes

Assignees

@jbogarthyde jbogarthyde

Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours freq2: medium risk: low target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbogarthyde @mary-poppins @StephenFluin @googlebot